Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NotFoundError as an exception type #22

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Add NotFoundError as an exception type #22

merged 1 commit into from
Nov 22, 2022

Conversation

bachya
Copy link
Owner

@bachya bachya commented Nov 22, 2022

Describe what the PR does:

This PR adds a more specific exception type for the cases where we request a resource (such as a sensor by index) that can't be found.

Does this fix a specific issue?

N/A

Checklist:

  • Confirm that one or more new tests are written for the new functionality.
  • Run tests and ensure everything passes (with 100% test coverage).
  • Update README.md with any new documentation.
  • Add yourself to AUTHORS.md.

@bachya bachya added the enhancement Enhancement of the code, not introducing new features. label Nov 22, 2022
@bachya bachya self-assigned this Nov 22, 2022
@codeclimate
Copy link

codeclimate bot commented Nov 22, 2022

Code Climate has analyzed commit 6538e4a and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #22 (6538e4a) into dev (534992e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          479       481    +2     
=========================================
+ Hits           479       481    +2     
Impacted Files Coverage Δ
aiopurpleair/errors.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bachya bachya merged commit 16a7479 into dev Nov 22, 2022
@bachya bachya deleted the notfound branch November 22, 2022 02:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant